Re: [PATCH 01/22] gnu: parallel: Use full paths for executables.

[Leo Famulari]

On Wed, Jul 27, 2016 at 10:54:02PM +1000, Ben Woodcroft wrote:
> * gnu/packages/parallel.scm (parallel)[inputs]: Add procps.
> [arguments]: New field.

> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (add-after 'unpack 'patch-bin-sh
> +           (lambda _
> +             (for-each
> +              (lambda (file)
> +                (substitute* file
> +                  ;; Patch hard coded '/bin/sh' in the lin ending in:
> +                  ;; $Global::shell = $ENV{'PARALLEL_SHELL'} ||
> +                  ;;  parent_shell($$) || $ENV{'SHELL'} || "/bin/sh";
> +                  (("/bin/sh\\\";\n$") (string-append (which "sh") "\";\n"))
> +                  ;; Patch call to 'ps' and 'perl' commands.
> +                  ((" ps ") (string-append " " (which "ps") " "))
> +                  ((" perl -") (string-append " " (which "perl") " -"))))
> +              (list "src/parallel" "src/sem"))))
> +         (add-after 'install 'post-install-test
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (zero? (system* (string-append
> +                              (assoc-ref outputs "out") "/bin/parallel")
> +                             "echo"
> +                             ":::" "1" "2" "3")))))))

Do we need the 'post-install-test' phase, or was it left in by accident after
debugging?