Re: [PATCH] update notmuch and python bindings

[ng0]

Troy Sankey <address@hidden> writes:

> Updated patches address all comments so far except for the removal of
> the emacs input.  Also updated the test numbers just for fun.
>
> Quoting ng0 (2016-08-07 18:24:57)
>> I'd also advise to upgrade git to something more recent if your distro
>> allows it :)
>
> Debian stable :)  It's a long term project of mine to switch to GuixSD.
> I'm switching over one package at a time.  Next is notmuch!

Maybe git 2.9.x is in backports.. I'm just pointing this out because
recently someone told me about security issues with certain versions of
git.

>> I'll try to test build tomorrow morning when my buildserver is up
>> again. release notes read interesting enough. thanks for the patches.
>
> Thanks.
>
> Troy

> From 034a4ac3b1bc85ae574fbe9f79add609cf311cc1 Mon Sep 17 00:00:00 2001
> From: Troy Sankey <address@hidden>
> Date: Sun, 7 Aug 2016 13:21:28 -0400
> Subject: [PATCH 1/3] gnu: notmuch: Update to 0.22.1.
>
> This also removes the emacs input.  Quote from the notmuch NEWS file:
>
>   Drop dependency on "pkg-config emacs".
> ---
>  gnu/packages/mail.scm | 11 +++++------
>  1 file changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm
> index 28978a8..82e35fb 100644
> --- a/gnu/packages/mail.scm
> +++ b/gnu/packages/mail.scm
> @@ -436,18 +436,18 @@ attachments, create new maildirs, and so on.")
>  (define-public notmuch
>    (package
>      (name "notmuch")
> -    (version "0.21")
> +    (version "0.22.1")
>      (source (origin
>                (method url-fetch)
>                (uri (string-append "https://notmuchmail.org/releases/notmuch-";
>                                    version ".tar.gz"))
>                (sha256
>                 (base32
> -                "1cr53rbpkcy3pvrmhbg2gq7sjpwb0c8xd7a4zhzxbiv8s7z8yvyh"))))
> +                "0jwpda3q023dn3sp41n8648951i7iagfv8zzpriv7hpkjivlafg7"))))
>      (build-system gnu-build-system)
>      (arguments
> -     '(#:tests? #f ;; FIXME: 662 tests; 168 fail and 99 are skipped
> -                   ;; with perl input: 50 fail and 99 are skipped
> +     '(#:tests? #f ; FIXME: 694 tests; 170 fail and 100 are skipped
> +                   ; with perl input: 50 fail and 100 are skipped

I think this comment should not be updated in your patch, like I wrote
before someone should update the comment when either the whole file is
addressed in stylistic fixes or when the tests are changed from false to
true or something test related is changed. Your version bump does not do
this.

>         #:phases (modify-phases %standard-phases
>                    (replace 'configure
>                      (lambda* (#:key outputs #:allow-other-keys)
> @@ -464,8 +464,7 @@ attachments, create new maildirs, and so on.")
>         ("python-sphinx" ,python2-sphinx)
>         ("bash-completion" ,bash-completion)))
>      (inputs
> -     `(("emacs" ,emacs)
> -       ("glib" ,glib)
> +     `(("glib" ,glib)
>         ("gmime" ,gmime)
>         ("talloc" ,talloc)
>         ("xapian" ,xapian)
> -- 
> 2.1.4
>

-- 
♥Ⓐ  ng0
Current Keys: https://we.make.ritual.n0.is/ng0.txt
For non-prism friendly talk find me on http://www.psyced.org