[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 07/11] gnu: ncurses: support mingw.
From: |
Alex Kost |
Subject: |
Re: [PATCH 07/11] gnu: ncurses: support mingw. |
Date: |
Tue, 09 Aug 2016 10:53:27 +0300 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Jan Nieuwenhuizen (2016-08-09 09:41 +0300) wrote:
> * gnu/packages/patches/ncurses-mingw.patch: New file.
> * gnu-system.am (dist_patch_DATA): Add it.
> * gnu/packages/ncurses.scm (ncurses): Support mingw.
[...]
> (define-public ncurses
> @@ -36,6 +39,7 @@
> #:allow-other-keys)
> (let ((out (assoc-ref outputs "out"))
> (doc (assoc-ref outputs "doc")))
> + (format #t "configure flags: ~s~%" configure-flags)
> (zero? (apply system* "./configure"
> (string-append "SHELL=" (which "sh"))
> (string-append "--build=" build)
> @@ -60,33 +64,66 @@
> "mandir=share/man"))
> #t))
> (post-install-phase
> - '(lambda* (#:key outputs #:allow-other-keys)
> - (let ((out (assoc-ref outputs "out")))
> + `(lambda* (#:key outputs target #:allow-other-keys)
> + (let ((out (assoc-ref outputs "out"))
> + (mingw-target? (lambda* (#:optional (target target))
> + (and target
> + (string-suffix? "-mingw32" target))))
IIUC you don't use the same 'mingw-target?' procedure you added in an
earlier patch, because it is placed in (guix utils), right? I don't
know if (guix build utils) would be a better place for it, but I think
this 'mingw-target?' may be used by other packages quite often, so it
should be available by default to avoid the same definitions in other
packages.
--
Alex
- [PATCH 03/11] gnu: cross-build: i686-w64-mingw32: new cross target., (continued)
- [PATCH 07/11] gnu: ncurses: support mingw., Jan Nieuwenhuizen, 2016/08/09
- Re: [PATCH 07/11] gnu: ncurses: support mingw.,
Alex Kost <=
Re: [PATCH 07/11] gnu: ncurses: support mingw., Mark H Weaver, 2016/08/14
[PATCH 09/11] gnu: libtool: support cross-libtool mingw., Jan Nieuwenhuizen, 2016/08/09