guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 4/4] gnu: Add Tomb.


From: Leo Famulari
Subject: Re: [PATCH 4/4] gnu: Add Tomb.
Date: Tue, 23 Aug 2016 19:50:35 -0400
User-agent: Mutt/1.7.0 (2016-08-17)

On Tue, Aug 23, 2016 at 05:41:27PM -0500, Eric Bavier wrote:
> On Tue, 23 Aug 2016 16:50:59 -0400
> Leo Famulari <address@hidden> wrote:
> 
> > On Tue, Aug 23, 2016 at 01:15:12AM -0500, Eric Bavier wrote:
> > > +    (inputs                   ;users should install their preferred 
> > > pinentry-*
> > > +     `(("zsh" ,zsh)  
> > 
> > Does it really need the zsh shell?
> 
> Yes, "bin/tomb" is a Zsh script.

Wow, interesting. I will read it (not as part of patch review).

> 
> > 
> > > +       #:tests? #f                      ;requires root  
> > 
> > Too bad :/ A program like this should be tested.
> 
> I've tested most functionality manually.  But there is no way to get
> root in the build environment.  There may be some sanity tests that
> could be performed in a custom 'check phase, checks that don't need
> root.

Yes, there may be. I don't think it's a blocker, however.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]