[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] Alter the Builds table to have an id field
|
From: |
Ludovic Courtès |
|
Subject: |
Re: [PATCH 2/2] Alter the Builds table to have an id field |
|
Date: |
Sat, 25 Jan 2020 18:54:06 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Christopher Baines <address@hidden> skribis:
> The internal rowid's are used for builds as you can request builds by using
> the rowid in the URL.
>
> The motivation here is to enable running VACUUM operations in SQLite, without
> risking the rowid's for Builds changing. It would be bad if they change, as
> they're used in the URL's for builds.
>
> * src/schema.sql (Builds): Add id column.
> * src/sql/upgrade-6.sql: New file.
> * Makefile.am (dist_sql_DATA): Add it.
This and the previous one LGTM! :-)
Ludo'.