Re: branch master updated: gnu: Add warsow-qfusion.

[Marius Bakke]

Hi Pierre,

address@hidden writes:

> commit 39f1806ca1d04b9aee70e897e06466aadbbee152
> Author: Pierre Neidhardt <address@hidden>
> AuthorDate: Thu Apr 9 15:56:42 2020 +0200
>
>     gnu: Add warsow-qfusion.
>     
>     * gnu/local.mk (warsow-qfusion): New variable.

This commit message is weird.

> ---
>  gnu/local.mk                      |  1 +
>  gnu/packages/game-development.scm | 78 
> +++++++++++++++++++++++++++++++++++++++
>  2 files changed, 79 insertions(+)

warsow-qfusion-fix-bool-return-type.patch is missing, breaking the
build of both Guix and this package.

> +(define-public warsow-qfusion
> +  ;; As of 2020-04-09, the latest stable version 2.1.0 is deprecated.
> +  ;; The 2.5 beta as published on the homepage is commit
> +  ;; c4de15df559410aff0ca6643724e24cddb0ecbbd
> +  (let ((commit "c4de15df559410aff0ca6643724e24cddb0ecbbd")
> +        (arch (match (or (%current-target-system)
> +                         (%current-system))
> +                ("x86_64-linux" "x86_64")
> +                ("i686-linux" "i386")
> +                (_ ""))))

Don't do this if you just need to determine architecture at build time.

> +           (add-after 'install 'really-install
> +             (lambda* (#:key outputs #:allow-other-keys)
> +               (let ((out (assoc-ref outputs "out")))
> +                 (install-file (string-append 
> "../source/build/basewsw/libgame_"
> +                                              ,arch ".so")
> +                               (string-append out "/lib/"))
> +                 (install-file (string-append "../source/build/libui_" ,arch 
> ".so")
> +                               (string-append out "/lib/"))

Add it here instead.  There is also no need for the fallback value
as the package apparently only supports i686 and x86_64 according to
supported-systems.

> +      (synopsis "Warsow's fork of qfusion, the id Tech 2 derived game 
> engine")
> +      (supported-systems '("i686-linux" "x86_64-linux"))
> +      (description
> +       "This package contains Warsow's fork of qfusion, the id Tech 2 derived
> +game engine.  id Tech 2 is the engine originally behind Quake 2.")
> +      (license license:gpl2+))))

Nit-pick: could you put description immediately after synopsis?  Also,
please avoid restating the synopsis in the description, but try to
expand on it.  I.e. what is Warsow?  I thought it was a city!

Meanwhile I've reverted the commit so that 'make' works again.

Thanks!

signature.asc
Description: PGP signature