guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: guix lint false positives and RFC patch


From: Simon Tournier
Subject: Re: guix lint false positives and RFC patch
Date: Fri, 27 Jan 2023 18:42:53 +0100

Hi,

On sam., 12 nov. 2022 at 17:54, Vagrant Cascadian <vagrant@debian.org> wrote:
> On 2022-11-05, Ludovic Courtès wrote:
>> Vagrant Cascadian <vagrant@debian.org> skribis:
>>> From bfa13fdd3616839883e50efbbc05fb132610ce67 Mon Sep 17 00:00:00 2001
>>> From: Vagrant Cascadian <vagrant@debian.org>
>>> Date: Wed, 2 Nov 2022 19:56:12 -0700
>>> Subject: [PATCH 01/12] guix: lint: Exclude some "@" symbols from various
>>>  checks.
>>>
>>> The visual representation of "@code{}" or similar in the description and
>>> synopsis do not include the string, so exclude it from checks to avoid false
>>> positives.
>>>
>>> FIXME handle @command, @file, @acronym, etc.
>>>
>>> * guix/linx.scm (properly-starts-sentence): Exclude leading "@".
>>>   (check-synopsis-length): Exclude "@code" and "@acronym".
>>
>> LGTM!  Bonus points for a test in ‘tests/lint.scm’.  :-)
>
> No bonus points for me just yet...

[...]

> What is failing to match what here?

Well, almost done but not merged, right?

Still an issue this ’match’?


Cheers,
simon



reply via email to

[Prev in Thread] Current Thread [Next in Thread]