[savannah-help-public] [sr #108871] Gnash project's git mail notification is giving out wrong repository URL

[Nutchanon Wetchasit]

Follow-up Comment #2, sr #108871 (project administration):

After digging around the source code, I figured this problem might be related
to these lines
<http://git.savannah.gnu.org/cgit/administration.git/tree/git.txt?id=795299d6e3a29e9743411477539d663db3fd1b23#n185>
in Savannah administration sheet:

mkdir -m 755 $GIT_DIR/hooks/post-receive.d
chattr +i $GIT_DIR/hooks
ln -s /usr/src/git/contrib/hooks/post-receive-email
$GIT_DIR/hooks/post-receive.d/
git config hooks.showrev "t=%s; echo
http://git.savannah.gnu.org/cgit/${dir_git}/commit/?id=\$t; echo; echo; git
show -C \$t; echo"
git config hooks.mailinglist address@hidden
popd


You would see that the `hooks.showrev` line is using `${dir_git}` variable for
repository name. This variable is not assigned from anywhere in the sheet, so
I suspected that the correct one is actually `${GIT_DIR}` (which should be
"gnash.git"
<http://git.savannah.gnu.org/cgit/administration.git/tree/git.txt?id=795299d6e3a29e9743411477539d663db3fd1b23#n150>
in case of Gnash project).

See also: Git post-receive-email documentation
<https://git.kernel.org/cgit/git/git.git/tree/contrib/hooks/post-receive-email?id=4e59582ff70d299f5a88449891e78d15b4b3fabe#n56>

Fixing this in existing Git repositories would involve manual editing of Git's
`hooks.showrev` configuration property to add the repository name in; which
definitely require Savannah staff's intervention.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/support/?108871>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/