[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: AS_MKDIR_P bug/patch
From: |
Paul Eggert |
Subject: |
Re: AS_MKDIR_P bug/patch |
Date: |
26 Sep 2003 01:29:54 -0700 |
User-agent: |
Gnus/5.09 (Gnus v5.9.0) Emacs/21.3 |
Eric Sunshine <address@hidden> writes:
> 1) _AS_MKDIR_P_PREPARE behaves incorrectly on some platforms (such
> as NextStep and OpenStep) for which `mkdir' does not recognize any
> options. The existing implementation leaves a bogus directory named
> "-p" sitting in the working directory. The patch removes this bogus
> directory if present.
That sounds reasonable. Thanks for reminding us of the problem.
> 2) _AS_MKDIR_P_PREPARE neglects to take advantage of the older `mkdirs'
> command
The existing code runs correctly on these ancient hosts, doesn't it?
If so, I wouldn't bother with this part of the patch. We don't need
to optimize for ancient hosts.
I installed this.
2003-09-26 Paul Eggert <address@hidden>
* lib/m4sugar/m4sh.m4 (_AS_MKDIR_P_PREPARE): If mkdir -p . fails,
rm -fr ./-p to remove junk left behind on NextStep and OpenStep.
Problem reported by Eric Sunshine in:
http://mail.gnu.org/archive/html/autoconf-patches/2002-12/msg00014.html
Index: m4sh.m4
===================================================================
RCS file: /cvsroot/autoconf/autoconf/lib/m4sugar/m4sh.m4,v
retrieving revision 1.99
retrieving revision 1.100
diff -p -u -r1.99 -r1.100
--- m4sh.m4 1 Aug 2003 01:10:58 -0000 1.99
+++ m4sh.m4 26 Sep 2003 08:24:30 -0000 1.100
@@ -1,7 +1,7 @@
# This file is part of Autoconf. -*- Autoconf -*-
# M4 sugar for common shell constructs.
# Requires GNU M4 and M4sugar.
-# Copyright (C) 2000, 2001, 2002 Free Software Foundation, Inc.
+# Copyright (C) 2000, 2001, 2002, 2003 Free Software Foundation, Inc.
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
@@ -690,6 +690,7 @@ m4_defun([_AS_MKDIR_P_PREPARE],
[if mkdir -p . 2>/dev/null; then
as_mkdir_p=:
else
+ rm -fr ./-p
as_mkdir_p=false
fi
])# _AS_MKDIR_P_PREPARE