autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: _AC_CACHE_DUMP simplified


From: Ralf Wildenhues
Subject: Re: _AC_CACHE_DUMP simplified
Date: Tue, 21 Mar 2006 07:17:24 +0100
User-agent: Mutt/1.5.9i

Hi Stepan,

* Stepan Kasal wrote on Mon, Mar 20, 2006 at 11:11:40PM CET:
> Hello,
>   what would you say about this simplification of _AC_CACHE_DUMP?

I'd reject it.  AFAICS the new code mishandles newlines in a different
way, without adjusting the comment above the code, but what's more, it
does not filter out variable names not containing _cv_ in every case.

Cheers,
Ralf

> 2006-03-20  Stepan Kasal  <address@hidden>
> 
>       * lib/autoconf/general.m4 (_AC_CACHE_DUMP): Grep for `^ac_space'
>         so that the test is not fooled by variables containing string
>         `ac_space= '.  If there is no substitution needed, do not call sed.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]