[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: document AS_BASENAME
From: |
Eric Blake |
Subject: |
Re: document AS_BASENAME |
Date: |
Sat, 01 Apr 2006 09:59:14 -0700 |
User-agent: |
Thunderbird 1.5 (Windows/20051201) |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
According to Stepan Kasal on 4/1/2006 8:35 AM:
> I think it would be simpler to handle the corner cases once, by a shell
> ``case,'' and use expr||sed only for the non-trivial one.
>
>
> * lib/m4sugar/m4sh.m4 (AS_DIRNAME): Reimplement using AS_CASE.
> (AS_BASENAME): Likewise.
> (AS_DIRNAME_EXPR, AS_DIRNAME_SED, AS_BASENAME_EXPR, AS_BASENAME_SED):
> Nuke.
> * tests/m4sh.at (AS_DIRNAME, AS_BASENAME): Do not test the removed
> macros.
Also, if we are handling the special cases up front, then we can guarantee
that we are no longer calling 'basename /'. If we decide to take the
approach of your patch, then _AS_BASENAME_PREPARE becomes extraneous, and
you should delete it (since we would be removing the one reason we avoid a
platform basename).
- --
Life is short - so eat dessert first!
Eric Blake address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.1 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFELrFi84KuGfSFAYARApWyAJ9tEuq6x9KqAZb4hgCGUaaPBgu0JQCfbIrb
Hc60LkPDc2xAZqT84o08qJk=
=1N4R
-----END PGP SIGNATURE-----