autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: document AS_BASENAME


From: Eric Blake
Subject: Re: document AS_BASENAME
Date: Sat, 01 Apr 2006 12:14:11 -0700
User-agent: Thunderbird 1.5 (Windows/20051201)

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Stepan Kasal on 4/1/2006 10:13 AM:
> 
> 2) I'm not sure "basename /" is the only bug around.  The code shall be
> interpreted this way:
> 
>       "If it handles even basename /, we can hopefully trust it."
> 
> Thus I think it would be too adventurous to start using the buggy basename
> implementations right now, before the release.

True.

> 
> 3) Pre-computing the as_basename variable saves a subshell in each
> AS_BASENAME call with a non-trivial argument.  So _AS_BASENAME_PREPARE is
> an efficiency issue, too.  (I even considered adding _AS_DIRNAME_PREPARE.)

That's the clincher.  Actually, AS_DIRNAME is expanded more frequently
than AS_BASENAME in coreutils' configure, so I retract my previous
objection to leaving _AS_BASENAME_PREPARE, and would welcome the addition
of _AS_DIRNAME_PREPARE.

(I do some compatibility development on cygwin running on an old 266 MHz
Win98 machine, where every fork takes a full second of wall clock time, so
I know first hand how avoiding extra forks can speed up a shell script.)

- --
Life is short - so eat dessert first!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.1 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFELtEC84KuGfSFAYARAv0wAJ9tRj/QjDW8RJyu/mkVCFmXguYuHwCfS03K
xTeEe/jzQpp3VBq/zhNXKpM=
=wqnG
-----END PGP SIGNATURE-----




reply via email to

[Prev in Thread] Current Thread [Next in Thread]