Re: [RFA] autotest speedup

[Ralf Wildenhues]

Hello,

* Eric Blake wrote on Thu, Oct 04, 2007 at 08:34:39PM CEST:
> Paolo Bonzini <paolo.bonzini <at> lu.unisi.ch> writes:
> > 
> > This speeds up autotest generation by ~6% (15.9 to 15.1 seconds) by 
> > outlining detection of tracing into a shell function, and removing the 
> > at_trace_this variable
> 
> This would be the first use of shell functions in autotest.  I think we are 
> finally ready for this move - we've had the shell function sniffer out in the 
> wild for quite some time now, with only a few reports of failure, and even 
> then, it wasn't due to lack of functions, but to bugs that we can be careful 
> of 
> in our use of functions.

Let's announce this in NEWS.  Also, I noted that a function was renamed
later.  I fixed the ChangeLog entry in another commit:

Cheers,
Ralf

2007-10-10  Ralf Wildenhues  <address@hidden>

        * NEWS: Announce shell function usage in Autotest.

diff --git a/NEWS b/NEWS
index 53cee46..027a635 100644
--- a/NEWS
+++ b/NEWS
@@ -2,6 +2,8 @@ GNU Autoconf NEWS - User visible changes.
 
 * Major changes in Autoconf 2.61b (????-??-??)
 
+** Autotest now makes use of shell functions.
+
 ** config.status now uses awk instead of sed also for config headers.
 
    - As a side effect, AC_DEFINE and AC_DEFINE_UNQUOTED now handle multi-line


    Fix ChangeLog entry.

diff --git a/ChangeLog b/ChangeLog
index 7b4a6d7..f72a58b 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -95,6 +99,7 @@
        at_func_check_skip, at_func_check_status, at_func_filter_trace,
        at_func_log_failure shell functions.  Use test -s to avoid
        useless diff invocations.
+       (at_func_check_newline): Renamed from at_check_newline.
        (AT_SETUP): Define AT_captured_files to empty.
        (AT_DIFF_STDERR(*), AT_DIFF_STDOUT(*)): New, extracted from _AT_CHECK.
        (_AT_CHECK): Replace m4_case with m4_ifdef/m4_indir.  Use all