Re: AT_BANNER handling

[Eric Blake]

According to Eric Blake on 10/19/2007 10:00 PM:
> According to Ralf Wildenhues on 10/19/2007 11:17 AM:
>> Hello Eric,
> 
>> Your patch breaks
>>   ./testsuite -10 --list
> 
> I'll look into it; probably something in $at_groups_all changed how the
> awk script at the comment 'Passing at_groups is tricky.' reacts.  Oh - it
> must be because before my patch, the earlier awk script that parsed out
> banner numbers reformatted the list back into space-separated, not newline
> separated.

Indeed; this is what I just pushed:

From: Eric Blake <address@hidden>
Date: Sat, 20 Oct 2007 22:29:44 -0600
Subject: [PATCH] Fix testsuite --list subset.

* lib/autotest/general.m4 (AT_INIT) <at_list_p>: Swap newlines
back to spaces, before listing subset of tests.
Reported by Ralf Wildenhues.

Signed-off-by: Eric Blake <address@hidden>
---
 ChangeLog               |    7 +++++++
 lib/autotest/general.m4 |    5 +++++
 2 files changed, 12 insertions(+), 0 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 9603e32..af1c06e 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2007-10-20  Eric Blake  <address@hidden>
+
+       Fix testsuite --list subset.
+       * lib/autotest/general.m4 (AT_INIT) <at_list_p>: Swap newlines
+       back to spaces, before listing subset of tests.
+       Reported by Ralf Wildenhues.
+
 2007-10-19  Eric Blake  <address@hidden>

        s/parenthesis/parentheses/ where appropriate.
diff --git a/lib/autotest/general.m4 b/lib/autotest/general.m4
index 012633c..aa29202 100644
--- a/lib/autotest/general.m4
+++ b/lib/autotest/general.m4
@@ -653,6 +653,11 @@ _ATEOF
   # Passing at_groups is tricky.  We cannot use it to form a literal string
   # or regexp because of the limitation of AIX awk.  And Solaris' awk
   # doesn't grok more than 99 fields in a record, so we have to use `split'.
+  # at_groups needs to be space-separated for this script to work.
+  case $at_groups in
+    *"$as_nl"* )
+      at_groups=`AS_ECHO(["$at_groups"]) | tr "$as_nl" ' '` ;;
+  esac
   AS_ECHO(["$at_groups$as_nl$at_help_all"]) |
     awk 'BEGIN { FS = ";" }
         NR == 1 {
-- 
1.5.3.2

-- 
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden