autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: r150960 changed ltmain.sh and broke the build


From: Eric Blake
Subject: Re: r150960 changed ltmain.sh and broke the build
Date: Thu, 27 Aug 2009 06:36:12 -0600
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.23) Gecko/20090812 Thunderbird/2.0.0.23 Mnenhy/0.7.6.666

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Ralf Wildenhues on 8/26/2009 12:22 PM:
> 
> How about
> 
>      Patterns should not include the separator (unless escaped), even
>      as part of a character class.  In conformance with Posix, the Cray
>      `sed' rejects `s/[^/]*$//': use `s,[^/]*$,,'.  Even escaped,

I'd rather recommend 's|[^/]*$||' instead, consistent with the rest of our
recommendations to prefer | over non-shell-metacharacters.

>      patterns should not include separators that are also used as
>      metacharacters.  For example, GNU sed 3.02 rejects `s,x\{1\,\},,',

s/as metacharacters/as sed metacharacters/

>      and is used on MinGW.

I guess you were trying to point out that GNU sed 3.02 is what is
currently in use on MinGW?  That wording came across a bit awkwardly; how
about:

For example, MinGW ships with GNU sed 3.02, which rejects `s,x\{1\,\},,'.

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkqWfbwACgkQ84KuGfSFAYCP1gCguhP9gjYiLnexe5z1JeIeHPZq
wnQAnRBdqJMARKbZCgkWrpfh73CDKGGe
=lnwd
-----END PGP SIGNATURE-----




reply via email to

[Prev in Thread] Current Thread [Next in Thread]