Re: [FYI] {master} refactor: use modern semantics of 'open'

[Eric Blake]

On 04/26/2012 05:12 AM, Stefano Lattarini wrote:
> Hi Eric, sorry for the delay.
> 
> On 04/25/2012 01:25 AM, Eric Blake wrote:
>>
>> Actually, this appears to make _all_ the XFile uses work; all that
>> remains broken is places such as bin/autoupdate.in calling raw open
>> instead of using XFile.
>>
>>>>
>>>> diff --git i/lib/Autom4te/XFile.pm w/lib/Autom4te/XFile.pm
>>>> index 19b73aa..95a452b 100644
>>>> --- i/lib/Autom4te/XFile.pm
>>>> +++ w/lib/Autom4te/XFile.pm
>>>> @@ -138,7 +138,14 @@ sub open
>>>>    # comment in IO::Handle.
>>>>    ${*$fh}{'autom4te_xfile_file'} = "$file";
>>>>
>>>> -  if (!$fh->SUPER::open (@_))
>>>> +  if (defined $mode && "$file" eq '-')
>>>> +    {
>>>> +      if (!$fh->SUPER::open ("$mode$file"))
>>>>
> What if "mode" is something like "w" or "r+"?

I hadn't thought about that - but we would indeed need to add some
smarts to XFile to handle it properly.

>>
>> In other words, since the point of XFile is to ensure binmode, and to
>> make open nicer to use, making XFile the owner of '-' magic seems like
>> the right thing to do, and the real remaining autoconf bug is that we
>> aren't using XFile everywhere.
>>
> Makes sense.
> 
>>>
>>> If anything, this issue shows that the Automake::XFile module (and
>>> other similar modules as well) should live in their own git
>>> repository, which both Autoconf and Automake should use as a
>>> submodule -- and which (for $DEITY's sake!), should be unit-tested.
>>> Any volunteer?
>>
>> Alas, my perl-fu is weak enough that I'm not sure how good my
>> unit-testing attempts would be.  But moving the files to a common
>> repository seems doable (how about gnulib?).
>>
> This could be a good "interim" solution, as I the paperwork in place for
> Gnulib, as well as pushing rights for its repository.  Unit tests can be
> added later, as the need arise, and/or slowly step-by-step when we feel
> like doing so.

Would we move all .pm files, or just the .pm files that both automake
and autoconf are sharing?  (The list of shared files is:
Configure_ac.pm, Channels.pm, FileUtils.pm, Getopt.pm, XFile.pm)

-- 
Eric Blake   address@hidden    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature