[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: 64-simplify-handle-gettext.patch
From: |
Akim Demaille |
Subject: |
Re: 64-simplify-handle-gettext.patch |
Date: |
25 Feb 2001 19:53:31 +0100 |
User-agent: |
Gnus/5.0808 (Gnus v5.8.8) XEmacs/21.1 (Cuyahoga Valley) |
Tom Tromey <address@hidden> writes:
> >>>>> "Akim" == Akim Demaille <address@hidden> writes:
>
> Akim> + &am_line_error ('SUBDIRS',
> Akim> + "AM_GNU_GETTEXT used but \`po' not in SUBDIRS")
> Akim> + if $contents{'SUBDIRS'} !~ /\bpo\b/;
> Akim> + &am_line_error ('SUBDIRS',
> Akim> + "AM_GNU_GETTEXT used but \`intl' not in SUBDIRS")
> Akim> + if $contents{'SUBDIRS'} !~ /\bintl\b/;
>
> This code -- and the old code, I admit -- is broken.
> Random bits of code shouldn't look at $contents{...}.
> Instead they have to use &variable_value or &variable_value_as_list.
> That's because the variable might be conditionally defined.
>
> Can you update the patch to do this? With that minor change it is ok.
I did this:
&am_line_error ('SUBDIRS',
"AM_GNU_GETTEXT used but \`po' not in SUBDIRS")
if &variable_value ('SUBDIRS') !~ /\bpo\b/;
&am_line_error ('SUBDIRS',
"AM_GNU_GETTEXT used but \`intl' not in SUBDIRS")
if &variable_value ('SUBDIRS') !~ /\bintl\b/;