bison-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-gnulib] Re: mbswidth.c portability fix for UnixWare 7.1.1


From: Bruno Haible
Subject: Re: [Bug-gnulib] Re: mbswidth.c portability fix for UnixWare 7.1.1
Date: Mon, 3 Mar 2003 18:25:20 +0100 (CET)

Paul Eggert writes:
> I installed the following patch into Bison.  OK to check into gnulib?
> It seems pretty straightforward.
> 
> 2003-02-28  Paul Eggert  <address@hidden>
> 
>       * lib/mbswidth.c: Include <wchar.h> before "mbswidth.h", to work
>       around a UnixWare 7.1.1 porting bug reported by John Hughes in
>       <http://mail.gnu.org/archive/html/bug-bison/2003-02/msg00030.html>.

I prefer to fix this by changing mbswidth.h to do the

#if HAVE_WCHAR_H
# include <wchar.h>
#endif

This way
  1. the ordering problem will be fixed not only in mbswidth.c but
     also in other files that happen to use both mbswidth.h and
     wchar.h (such as ls.c),
  2. the specification header can be kept being included first,
     after only "config.h" and <alloca.h>, which is a generally useful
     rule.

Bruno




reply via email to

[Prev in Thread] Current Thread [Next in Thread]