[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: FYI: scan-gram.l globals -> static
|
From: |
Paul Eggert |
|
Subject: |
Re: FYI: scan-gram.l globals -> static |
|
Date: |
Mon, 14 Aug 2006 15:23:49 -0700 |
|
User-agent: |
Gnus/5.1008 (Gnus v5.10.8) Emacs/21.4 (gnu/linux) |
"Joel E. Denny" <address@hidden> writes:
> 2006-08-14 Joel E. Denny <address@hidden>
>
> + * src/scan-gram.l (braces_level, context_state): Make these globals
> + static.
Those aren't globals -- they are local variables for the scanner.
So this change hurts performance and makes the scanner less reentrant.
Is this change really needed? If not, can you please undo it, and
review other changes you've checked in recently for similar problems?