bison-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: push parser


From: Joel E. Denny
Subject: Re: push parser
Date: Tue, 19 Dec 2006 18:10:48 -0500 (EST)

On Tue, 19 Dec 2006, Paul Eggert wrote:

> "Joel E. Denny" <address@hidden> writes:
> 
> > -    int yytoken;
> > +    int yytoken]b4_push_if([], [[ = 0]])[;
> 
> How about if we leave this line alone, and put an initialization
> statement 'yytoken = 0;' elsewhere?  That sounds a bit cleaner.
> Similarly for the other initializations like this.
> 
> Other than that, it looks OK to me.

Actually that's my plan.  Somehow the above ugliness just made this diff a 
little easier to read.  If I promise that a future patch will clean this 
up, is it ok to commit this one?




reply via email to

[Prev in Thread] Current Thread [Next in Thread]