[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/6] warnings: fusion of complain and complain_at
From: |
Akim Demaille |
Subject: |
Re: [PATCH 2/6] warnings: fusion of complain and complain_at |
Date: |
Mon, 1 Oct 2012 15:29:57 +0200 |
Le 1 oct. 2012 à 17:00, Theophile Ranquet a écrit :
> These functions are very similar, and keeping them seperate makes
> future improvements difficult, so merge them.
>
> This impacts 89 calls.
>
> * NEWS: Document this change.
> * src/bootrap.conf: Adjust.
> * src/complain.c (complain, complain_at): Merge into one function,
> 'complain', that take an additional location pointer as an argument.
> (complain_args): Adjust.
> * src/complain.h, src/conflicts.c, src/files.c, src/getargs.c,
> src/gram.c, src/location.c, src/muscle-tab.c, src/parse-gram.y,
> src/reader.c, src/reduce.c, src/scan-code.l, src/scan-gram.l,
> src/scan-skel.l, src/symlist.c, src/symtab.c: Adjust.
Thanks, installed in master without the NEWS bits (these
changes are not visible by the Bison user), and with the
following commit message (fixed spello on bootstrap, and
fix the format of the entry on the fused complain):
commit bb8e56ff67d289d15f1a4dc7f5e1502cd3bbfc24
Author: Theophile Ranquet <address@hidden>
Date: Mon Oct 1 13:44:20 2012 +0000
warnings: fusion of complain and complain_at
These functions are very similar, and keeping them seperate makes
future improvements difficult, so merge them.
This impacts 89 calls.
* src/bootstrap.conf: Adjust.
* src/complain.c (complain, complain_at): Merge into...
(complain): this.
(complain_args): Adjust.
* src/complain.h, src/conflicts.c, src/files.c, src/getargs.c,
* src/gram.c, src/location.c, src/muscle-tab.c, src/parse-gram.y,
* src/reader.c, src/reduce.c, src/scan-code.l, src/scan-gram.l,
* src/scan-skel.l, src/symlist.c, src/symtab.c:
Adjust.
Signed-off-by: Akim Demaille <address@hidden>
- [PATCH 4/6] formatting changes, (continued)
- [PATCH 4/6] formatting changes, Theophile Ranquet, 2012/10/01
- [PATCH 3/6] warnings: organize variadic complaints call, Theophile Ranquet, 2012/10/01
- [PATCH 5/6] warnings: refactoring, Theophile Ranquet, 2012/10/01
- [PATCH 6/6] warnings: separate flags_argmatch, Theophile Ranquet, 2012/10/01
- [PATCH 2/6] warnings: fusion of complain and complain_at, Theophile Ranquet, 2012/10/01
- Re: [PATCH 2/6] warnings: fusion of complain and complain_at,
Akim Demaille <=