Re: RFC: lalr1.cc: support move semantics

[Hans Åberg]

> On 13 Sep 2018, at 06:51, Akim Demaille <address@hidden> wrote:
> 
> 
> 
>> Le 12 sept. 2018 à 23:46, Frank Heckenbach <address@hidden> a écrit :
>> 
>> Hans Åberg wrote:
>> 
>>>>>> Modern C++ (i.e., C++11 and later) introduced "move only" types: types 
>>>>>> such
>>>>>> as std::unique_ptr<T> that can never be duplicated.  They must never be
>>>>>> copied (by assignments and constructors), they must be "moved".  The
>>>>>> implementation of lalr1.cc used to copy symbols (including their semantic
>>>>>> values).  This commit ensures that values are only moved in modern C++, 
>>>>>> yet
>>>>>> remain compatible with C++98/C++03.
>>>>> 
>>>>> Hopefully copy only types can still be used. So say:
>>>> 
>>>> C++ will automatically copy when copy is available and move is not.
>>> 
>>> Yes, but strictly, that is not what the above text says.
>> 
>> Depends on your definitions. IMHO in (modern) C++ "move" always
>> implies "copy" if possible and necessary, though I wouldn't object
>> to spelling it out here.
> 
> So I went for what follows.
> 
> Should I consider this commit to be validated?  I don’t think
> there will be more reviewers than you two guys :/

Yes, from my point of view. It is just a commit comment. More detail can be put 
in code comments and the documentation.