[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for Dlang support 1/2] d: change the return value of yylex fr
|
From: |
H. S. Teoh |
|
Subject: |
Re: [PATCH for Dlang support 1/2] d: change the return value of yylex from TokenKind to YYParser.Symbol |
|
Date: |
Fri, 20 Nov 2020 10:45:38 -0800 |
On Fri, Nov 20, 2020 at 08:42:50PM +0200, Adela Vais wrote:
> Hello H. S.,
>
> În vin., 20 nov. 2020 la 20:31, H. S. Teoh <hsteoh@quickfur.ath.cx> a scris:
[...]
> > Is YYLocation a struct? If so, you should not use `new`, because
> > that incurs a GC allocation per construction.
> >
> > If not, it probably should be made one, since as far as I can tell
> > it's only used for storing a start/end point for position, is not
> > polymorphic, and therefore does not need to be a class.
> >
>
> I took into account what we discussed, this is commit 1/2, the above
> change is in commit 2/2. Thank you again for your help!
Ah, I see. Sorry about the false alarm then. :-)
> Should I make a squash with these 2 commits? I was thinking that they
> focus on different things and this is why I kept them separate.
I'll let Akim answer that.
--T