Re: Hang in bgp_delete

[Chet Ramey]

On 2/11/17 5:04 PM, Graham Northup wrote:

> Bash Version: 4.4
> Patch Level: 11
> Release Status: release
> 
> Description:
> 
> I'm getting a mysterious hang on one of our Arch Linux machines for a
> particular, rather simple script; getting a debugger attached to the
> process after building some debugging symbols, I tracked the hang down
> to this loop in bgp_delete (with some minor formatting):

It seems obvious in retrospect that the cause is in bgp_add, where there's
no check for the hashed pid colliding with the index into the pidstat list.
Here's a patch that avoids that issue and catches the symptom you found in
case the cause is something else.

Chet

-- 
``The lyf so short, the craft so long to lerne.'' - Chaucer
                 ``Ars longa, vita brevis'' - Hippocrates
Chet Ramey, UTech, CWRU    chet@case.edu    http://cnswww.cns.cwru.edu/~chet/

jobs-pid-collision.patch
Description: Source code patch

signature.asc
Description: OpenPGP digital signature