[Bug binutils/2593] Cannot set the CONTENTS or LOAD flags

[andrew dot stubbs at st dot com]

------- Additional Comments From andrew dot stubbs at st dot com  2006-04-21 
16:05 -------
Subject: Re:  New: Cannot set the CONTENTS or LOAD flags

[moving the conversation to bugzilla ...]

Thanks H.J., but this does not seem to work for me. I cannot see any 
difference.

> On Fri, Apr 21, 2006 at 01:58:08PM +0100, Andrew STUBBS wrote:
>> > Hi all,
>> > 
>> > I have encountered an error setting the CONTENTS and LOAD flags with 
>> > relatively recent versions of objcopy/bfd.
>> > 
> 
> Could you please open a bug report with a simple testcase? This patch
> should work.
> 
> Thanks.
> 
> 
> H.J.
> ----
> 2006-04-21  H.J. Lu  <address@hidden>
> 
>       * elf.c (_bfd_elf_new_section_hook): Don't set section ELF type
>       and flags if its BFD flags has been set.
> 
> --- bfd/elf.c.copy    2006-04-21 07:00:02.000000000 -0700
> +++ bfd/elf.c 2006-04-21 07:32:26.000000000 -0700
> @@ -2487,10 +2487,11 @@ _bfd_elf_new_section_hook (bfd *abfd, as
>    bed = get_elf_backend_data (abfd);
>    sec->use_rela_p = bed->default_use_rela_p;
>  
> -  /* When we read a file, we don't need section type and flags unless
> -     it is a linker created section.  They will be overridden in
> -     _bfd_elf_make_section_from_shdr anyway.  */
> -  if (abfd->direction != read_direction
> +  /* When we read a file or section BFD flags has been set, we don't
> +     need section type and flags unless it is a linker created section.
> +     They will be overridden in _bfd_elf_make_section_from_shdr
> +     anyway.  */
> +  if ((!sec->flags && abfd->direction != read_direction)
>        || (sec->flags & SEC_LINKER_CREATED) != 0)
>      {
>        ssect = (*bed->get_sec_type_attr) (abfd, sec);
> 



-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=2593

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.