[Bug gold/15574] Gold is overly pedantic for dynamic references to symbols with hidden visibility

[ccoutant at google dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=15574

--- Comment #4 from Cary Coutant <ccoutant at google dot com> ---
> --- gold/resolve.cc.orig    2013-11-04 15:33:39.000000000 +0000
> +++ gold/resolve.cc
> @@ -276,8 +276,7 @@ Symbol_table::resolve(Sized_symbol<size>
>        to->set_in_reg();
>      }
>    else if (st_shndx == elfcpp::SHN_UNDEF
> -           && (to->visibility() == elfcpp::STV_HIDDEN
> -               || to->visibility() == elfcpp::STV_INTERNAL))
> +           && (to->visibility() == elfcpp::STV_INTERNAL))
>      {
>        // A dynamic object cannot reference a hidden or internal symbol
>        // defined in another object.

With your patch, the hidden symbol will end up in the dynamic symbol
table. See PR 10471. I think the proper patch would be to remove the
warning, but still return immediately.

-cary

-- 
You are receiving this mail because:
You are on the CC list for the bug.