[Bug binutils/24421] New: Wrong brackets in opcodes/arm-dis.c

[enyby at yandex dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=24421

            Bug ID: 24421
           Summary: Wrong brackets in opcodes/arm-dis.c
           Product: binutils
           Version: unspecified
            Status: UNCONFIRMED
          Severity: minor
          Priority: P2
         Component: binutils
          Assignee: unassigned at sourceware dot org
          Reporter: enyby at yandex dot com
  Target Milestone: ---

File opcodes/arm-dis.c line 3694:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=blob;f=opcodes/arm-dis.c;h=d47ef32b974cf49d484ebc656980221a89fd7b45;hb=HEAD#l3694

3692                 case '0': case '1': case '2': case '3': case '4':
3693                 case '5': case '6': case '7': case '8': case '9':
3694                   {
3695                     int width;
3696 
3697                     c = arm_decode_bitfield (c, given, &value, &width);

On line 3694 open curly bracket.
It must be closed at line 3839 after switch. But it closed at line 4022 near
end parent switch.

If remove some inner blocks, code look like:

3692                 case '0': case '1': case '2': case '3': case '4':
3693                 case '5': case '6': case '7': case '8': case '9':
3694                   {
3695                     int width;
3696 
3697                     c = arm_decode_bitfield (c, given, &value, &width);
3698 
3699                     switch (*c)
3700                       {
3838                       }
3839                     break;
3840 
3841                   case 'y':
3842                   case 'z':
3921                     break;
3922 
3923                   case 'L':
3933                     break;
3934 
3935                   case 'Z':
3941                     break;
3942 
3943                   case 'l':
3975                     break;
3976 
3977                   case 'r':
4010                     break;
4011 
4012                   case 'i':
4018                     break;
4019 
4020                   default:
4021                     abort ();
4022                   }
4023                 }

It is not lead to any damage in C/C++, but code smell.

-- 
You are receiving this mail because:
You are on the CC list for the bug.