[Bug gold/20114] Partial relro support for s390x gold

[krebbel at linux dot ibm.com]

https://sourceware.org/bugzilla/show_bug.cgi?id=20114

--- Comment #5 from Andreas Krebbel <krebbel at linux dot ibm.com> ---
(In reply to maamountki from comment #4)
Looks good to me. However, I'm not a Gold maintainer.

One difference to the ld implementation is that you appear to always use the
new got layout. ld uses the new layout only for partial relro to keep impact on
existing stuff as small as possible. On the other hand the new layout is
supposed to be compatible to the old one. Switching to the new one
unconditionally should be ok for Gold I think. It also keeps the code much
simpler.

Have you checked that all this works with linker scripts as well. I mean linker
scripts which have got and got.plt swapped? Will gold do the right thing for
these variants with regard to the 3 magic entries, _GLOBAL_OFFSET_TABLE_, and
DT_PLTGOT?

-- 
You are receiving this mail because:
You are on the CC list for the bug.