[Bug binutils/29075] objdump -S does not support debuginfod

[nickc at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=29075

--- Comment #23 from Nick Clifton <nickc at redhat dot com> ---
(In reply to Aaron Merey from comment #22)
Hi Aaron,

> I've attached an updated patch. I took Nick's original patch and added a
> function _bfd_elf_find_nearest_line_with_alt to bfd/elf.c.

The patch looks good to me apart from one minor issue.  The function
_bfd_dwarf2_find_nearest_line_with_alt() is supposed to return an integer 
value, but most of the time the code inside the function treats the return
as a boolean.  For example there are several "return false" statements.
Whilst the code works, it is slightly inelegant.

Talking of _bfd_dwarf2_find_nearest_line_with_alt() returning false, it 
might be helpful if it also set a bfd_error code, so that caller's can
determine why it failed.  Maybe bfd_error_invalid_operation ?

Cheers
  Nick

-- 
You are receiving this mail because:
You are on the CC list for the bug.