Re: 2.4.1a testsuite failures on Solaris 2.7

[Joel E. Denny]

On Mon, 1 Feb 2010, Albert Chin wrote:

> > Thanks for the report.  In tests/atlocal, please try adding
> > 
> >   $abs_top_builddir/lib/libbison.a
> > 
> > to the value of LIBS.
> 
> Thanks. That worked.

Thanks for confirming.

I pushed the following to branch-2.4.2.  A previous patch already handled 
this on branch-2.5 and master where the problem affected more platforms.

>From d093cf8cbd50c8fa888640b8487e3f517063aa28 Mon Sep 17 00:00:00 2001
From: Joel E. Denny <address@hidden>
Date: Mon, 1 Feb 2010 15:54:41 -0500
Subject: [PATCH] tests: link lib/libbison.a for gnulib.

This solves a problem on Solaris 2.7 where the testsuite needs
at least gnulib's rpl_fopen.  Reported by Albert Chin at
<http://lists.gnu.org/archive/html/bug-bison/2010-02/msg00001.html>.
* NEWS (2.4.2): Document.
* tests/atlocal.in (LIBS): As for LDADD in src/Makefile.am, add
lib/libbison.a.
---
 ChangeLog        |   10 ++++++++++
 NEWS             |    3 +++
 tests/atlocal.in |    2 +-
 3 files changed, 14 insertions(+), 1 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 8f66ace..b54880b 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,13 @@
+2010-02-01  Joel E. Denny  <address@hidden>
+
+       tests: link lib/libbison.a for gnulib.
+       This solves a problem on Solaris 2.7 where the testsuite needs
+       at least gnulib's rpl_fopen.  Reported by Albert Chin at
+       <http://lists.gnu.org/archive/html/bug-bison/2010-02/msg00001.html>.
+       * NEWS (2.4.2): Document.
+       * tests/atlocal.in (LIBS): As for LDADD in src/Makefile.am, add
+       lib/libbison.a.
+
 2010-01-22  Joel E. Denny  <address@hidden>
 
        Prepare for 2.4.2 release.
diff --git a/NEWS b/NEWS
index 7cb3d4e..9b33d13 100644
--- a/NEWS
+++ b/NEWS
@@ -3,6 +3,9 @@ Bison News
 
 * Changes in version 2.4.2 (????-??-??):
 
+** Some portability problems in the testsuite that resulted in failures
+   on at least Solaris 2.7 have been fixed.
+
 ** `%prec IDENTIFIER' requires IDENTIFIER to be defined separately.
 
   POSIX specifies that an error be reported for any identifier that does
diff --git a/tests/atlocal.in b/tests/atlocal.in
index fc81849..8177209 100644
--- a/tests/atlocal.in
+++ b/tests/atlocal.in
@@ -28,7 +28,7 @@ CXXFLAGS='@O0CXXFLAGS@ @WARN_CXXFLAGS_TEST@ @WERROR_CFLAGS@'
 LDFLAGS='@LDFLAGS@'
 
 # Are special libraries needed?
-LIBS='@LIBS@ @INTLLIBS@'
+LIBS="$abs_top_builddir/lib/libbison.a @LIBS@ @INTLLIBS@"
 
 # Empty if no javac was found
 CONF_JAVAC='@CONF_JAVAC@'
-- 
1.5.4.3