[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 10/11] quote consistently and make tests pass with new quotin
From: |
Akim Demaille |
Subject: |
Re: [PATCH 10/11] quote consistently and make tests pass with new quoting from gnulib |
Date: |
Wed, 22 Feb 2012 17:04:37 +0100 |
Le 17 févr. 2012 à 09:47, Paul Eggert a écrit :
> On 02/17/2012 12:39 AM, Akim Demaille wrote:
>> there would
>> remain the question: should quotearg and quote use the same
>> default style?
>
> There's probably enough use of both, and assumption that the
> styles differ, that we should probably not try to merge the
> styles.
Hi Paul,
This is a proposal for quote fusion into quotearg.
In order to make the transition easier, I don't think
we should truly remove the quote module; but as an
implementation detail, its implementation is part
of quotearg.
So I kept quote.h, and avoided including quotearg.h
from there. But I moved the implementation of quote.c
into quotearg.c so that I can define a static
quote_quoting_option. Arguably, quotearg_colon should
now be quote_colon IMHO, and live in quote rather than
quotearg, but that's very minor.
What do you think about these patches?
0001-quote-fuse-into-quotearg.patch
Description: Binary data
0003-tests-be-robust-to-quote-style.patch
Description: Binary data
- Re: [PATCH 10/11] quote consistently and make tests pass with new quoting from gnulib, (continued)
- Re: [PATCH 10/11] quote consistently and make tests pass with new quoting from gnulib, Paul Eggert, 2012/02/02
- Re: [PATCH 10/11] quote consistently and make tests pass with new quoting from gnulib, Akim Demaille, 2012/02/08
- Re: [PATCH 10/11] quote consistently and make tests pass with new quoting from gnulib, Akim Demaille, 2012/02/08
- Re: [PATCH 10/11] quote consistently and make tests pass with new quoting from gnulib, Akim Demaille, 2012/02/16
- Re: [PATCH 10/11] quote consistently and make tests pass with new quoting from gnulib, Paul Eggert, 2012/02/16
- Re: [PATCH 10/11] quote consistently and make tests pass with new quoting from gnulib, Akim Demaille, 2012/02/16
- Re: [PATCH 10/11] quote consistently and make tests pass with new quoting from gnulib, Paul Eggert, 2012/02/17
- Re: [PATCH 10/11] quote consistently and make tests pass with new quoting from gnulib, Akim Demaille, 2012/02/17
- Re: [PATCH 10/11] quote consistently and make tests pass with new quoting from gnulib, Paul Eggert, 2012/02/17
- Re: [PATCH 10/11] quote consistently and make tests pass with new quoting from gnulib, Akim Demaille, 2012/02/21
- Re: [PATCH 10/11] quote consistently and make tests pass with new quoting from gnulib,
Akim Demaille <=
- Re: [PATCH 10/11] quote consistently and make tests pass with new quoting from gnulib, Paul Eggert, 2012/02/08
- Re: [PATCH 10/11] quote consistently and make tests pass with new quoting from gnulib, Akim Demaille, 2012/02/08
- Re: [PATCH 10/11] quote consistently and make tests pass with new quoting from gnulib, Paul Eggert, 2012/02/08