Re: [GNU Bison 2.5] testsuite: 3 4 7 8 16 21 33 36 45 68 69 70 92 93 94 95 139 143 145 151 160 220 221 222 228 233 246 failed

[Akim Demaille]

Le 5 mars 2012 à 19:39, Akim Demaille a écrit :

> Hum.  The most probable issue is that you have
> POSIXLY_CORRECT defined in your environment.  The
> test suite is robust to this provided that it
> is defined to 1:
> 
>        # POSIXLY_CORRECT=1 causes bison to complain if options are added
>        # after the grammar file name, so skip these checks in that case.
>        if test x"$POSIXLY_CORRECT" != x1; then
> 
> Indeed, we should not check for =1, but just being
> defined.

I installed this in maint, and will install it in master
when I'm done with the other pending patches.

From c14ceb55b9dd1961a8e234dfd789b31d7763604a Mon Sep 17 00:00:00 2001
From: Akim Demaille <address@hidden>
Date: Tue, 6 Mar 2012 09:09:02 +0100
Subject: [PATCH] tests: be robust to POSIXLY_CORRECT being defined.

* tests/local.at (AT_BISON_CHECK_NO_XML): Check if
POSIXLY_CORRECT is defined, not if it is defined to 1.
Reported by Lie Yan.
http://lists.gnu.org/archive/html/bug-bison/2012-03/msg00000.html
---
 THANKS         |    1 +
 tests/local.at |    7 ++++---
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/THANKS b/THANKS
index 5713bfc..6d0d89e 100644
--- a/THANKS
+++ b/THANKS
@@ -59,6 +59,7 @@ Juan Manuel Guerrero      address@hidden
 Kees Zeelenberg           address@hidden
 Keith Browne              address@hidden
 Laurent Mascherpa         address@hidden
+Lie Yan                   address@hidden
 Magnus Fromreide          address@hidden
 Marc Autret               address@hidden
 Martin Jacobs             address@hidden
diff --git a/tests/local.at b/tests/local.at
index a2aa568..f369315 100644
--- a/tests/local.at
+++ b/tests/local.at
@@ -279,9 +279,10 @@ m4_define([AT_BISON_CHECK_NO_XML],
                 [AT_QUELL_VALGRIND ])[[bison ]]$@)
 m4_if(m4_bregexp([$4], [: warning: ]), [-1], [],
       m4_quote(m4_if(m4_quote($2), [], [0], [$2])), [0], [[
-        # POSIXLY_CORRECT=1 causes bison to complain if options are added
-        # after the grammar file name, so skip these checks in that case.
-        if test x"$POSIXLY_CORRECT" != x1; then
+        # Defining POSIXLY_CORRECT causes bison to complain if options
+        # are added after the grammar file name, so skip these checks
+        # in that case.
+        if test -z "${POSIXLY_CORRECT+set}"; then
           # Don't interfere with caller's files.
           if test -f stderr; then mv stderr at-bison-check-stderr.bak; fi
           if test -f experr; then mv experr at-bison-check-experr.bak; fi
-- 
1.7.9.2