Re: 3.5: test suite fails

[Akim Demaille]

Hi Tomasz,

Thanks for the report!

Both failures are:

> 10. input.at:331: testing Symbol declarations ...
> ./input.at:369: COLUMNS=1000; export COLUMNS;  bison --color=no -fno-caret 
> -Wno-other -S./dump-symbols.m4 input.y
> --- /dev/null 2019-11-30 17:07:08.851263387 +0000
> +++ 
> /home/tkloczko/rpmbuild/BUILD/bison-3.5/tests/testsuite.dir/at-groups/10/stderr
>    2020-01-08 19:14:17.284197849 +0000
> @@ -0,0 +1,29 @@
> +==2837387== 320 bytes in 1 blocks are still reachable in loss record 1 of 1
> +==2837387==    at 0x483A80B: malloc (vg_replace_malloc.c:309)
> +==2837387==    by 0x117CFC: xmalloc (xmalloc.c:41)
> +==2837387==    by 0x11B743: UnknownInlinedFun (xalloc.h:103)
> +==2837387==    by 0x11B743: fstrcmp_bounded (fstrcmp.c:208)
> +==2837387==    by 0x142DED: UnknownInlinedFun (symtab.c:350)
> +==2837387==    by 0x142DED: UnknownInlinedFun (symtab.c:365)
> +==2837387==    by 0x142DED: UnknownInlinedFun (symtab.c:608)
> +==2837387==    by 0x142DED: UnknownInlinedFun (symtab.c:1017)
> +==2837387==    by 0x142DED: check_and_convert_grammar (reader.c:792)
> +==2837387==    by 0x1113E5: UnknownInlinedFun (reader.c:722)
> +==2837387==    by 0x1113E5: main (main.c:104)
> +==2837387== 
> +{
> +   <insert_a_suppression_name_here>
> +   Memcheck:Leak
> +   match-leak-kinds: reachable
> +   fun:malloc
> +   fun:xmalloc
> +   fun:UnknownInlinedFun
> +   fun:fstrcmp_bounded
> +   fun:UnknownInlinedFun
> +   fun:UnknownInlinedFun
> +   fun:UnknownInlinedFun
> +   fun:UnknownInlinedFun
> +   fun:check_and_convert_grammar
> +   fun:UnknownInlinedFun
> +   fun:main
> +}
> 10. input.at:331: 10. Symbol declarations (input.at:331): FAILED 
> (input.at:369)

i.e., an internal buffer that was not freed when Bison quitted.  The
API of this module (fstrcmp) does not allow to release the memory.
I'll see if gnulib guys are ok to make it possible, and keep you posted.

Cheers!