Convergence and Include in editfiles

[Andrew Stribblehill]

I think that the folllowing snippet is convergent. Can anyone
convince me otherwise, and preferably show me how to rewrite it in a
convergent manner?

editfiles:
  redhat::
    { /etc/sysconfig/network
    BeginGroupIfNoSuchLine "HOSTNAME=$(host)"
      ReplaceAll "HOSTNAME=.*" With "HOSTNAME=$(host)"
    EndGroup
    DefineClasses "changeHostname"
    }

When I run 'cfagent -ngq' I get the following:

cfengine:angel: WARNING: Non-convergent edit ReplaceAll [HOSTNAME=angel] With 
[HOSTNAME=.*]
cfengine:angel: Line begins [HOSTNAME=angel.dur.ac.uk]
cfengine:angel: Replace contains search string - edit was not done
cfengine:angel: Error editing file /etc/sysconfig/network

Apart from the oddity that the first [] is to my mind where the second []
should be, it's still weird.


The other question is: should the following be okay?

editfiles:
    { /etc/xinetd.d
    Include 'finger'
    Include 'rsh'
    Include 'rlogin'
    Include 'rexec'
    Include 'telnet'
    Include 'daytime'
    HashCommentLinesStarting '$(tab)disable'
    DefineClasses 'hupXinetd'
    }

When I run this, I get the following (cfagent -ngq) output:

cfengine:angel: Unknown action in editing of file /etc/xinetd.d/daytime
cfengine:angel: Unknown action in editing of file /etc/xinetd.d/daytime
cfengine:angel: Unknown action in editing of file /etc/xinetd.d/daytime
cfengine:angel: Unknown action in editing of file /etc/xinetd.d/daytime
cfengine:angel: Unknown action in editing of file /etc/xinetd.d/daytime
cfengine:angel: Unknown action in editing of file /etc/xinetd.d/daytime
cfengine:angel: Unknown action in editing of file /etc/xinetd.d/finger
cfengine:angel: Unknown action in editing of file /etc/xinetd.d/finger
cfengine:angel: Unknown action in editing of file /etc/xinetd.d/finger
cfengine:angel: Unknown action in editing of file /etc/xinetd.d/finger
cfengine:angel: Unknown action in editing of file /etc/xinetd.d/finger
cfengine:angel: Unknown action in editing of file /etc/xinetd.d/finger
cfengine:angel: Unknown action in editing of file /etc/xinetd.d/rexec
cfengine:angel: Unknown action in editing of file /etc/xinetd.d/rexec
cfengine:angel: Unknown action in editing of file /etc/xinetd.d/rexec
cfengine:angel: Unknown action in editing of file /etc/xinetd.d/rexec
cfengine:angel: Unknown action in editing of file /etc/xinetd.d/rexec
cfengine:angel: Unknown action in editing of file /etc/xinetd.d/rexec
cfengine:angel: Unknown action in editing of file /etc/xinetd.d/rlogin
cfengine:angel: Unknown action in editing of file /etc/xinetd.d/rlogin
cfengine:angel: Unknown action in editing of file /etc/xinetd.d/rlogin
cfengine:angel: Unknown action in editing of file /etc/xinetd.d/rlogin
cfengine:angel: Unknown action in editing of file /etc/xinetd.d/rlogin
cfengine:angel: Unknown action in editing of file /etc/xinetd.d/rlogin
cfengine:angel: Unknown action in editing of file /etc/xinetd.d/rsh
cfengine:angel: Unknown action in editing of file /etc/xinetd.d/rsh
cfengine:angel: Unknown action in editing of file /etc/xinetd.d/rsh
cfengine:angel: Unknown action in editing of file /etc/xinetd.d/rsh
cfengine:angel: Unknown action in editing of file /etc/xinetd.d/rsh
cfengine:angel: Unknown action in editing of file /etc/xinetd.d/rsh
cfengine:angel: Unknown action in editing of file /etc/xinetd.d/telnet
cfengine:angel: Unknown action in editing of file /etc/xinetd.d/telnet
cfengine:angel: Unknown action in editing of file /etc/xinetd.d/telnet
cfengine:angel: Unknown action in editing of file /etc/xinetd.d/telnet
cfengine:angel: Unknown action in editing of file /etc/xinetd.d/telnet
cfengine:angel: Unknown action in editing of file /etc/xinetd.d/telnet

Again, is there something I should do to stop these messages? In this
case, the work is done, but the messages are annoying.

-- 
NORTH UTSIRE SOUTH UTSIRE
WEST BACKING SOUTH 3 OR 4. SHOWERS DYING OUT. MAINLY GOOD