Exit status of 0 from cfkey despite failure

[Christian Pearce]

address@hidden sysnav]$ /opt/csw/sbin/cfkey
Making a key pair for cfengine, please wait, this could take a minute...
Ppen /var/sysnav/.cfagent/ppkeys/localhost.priv failed: Permission
address@hidden sysnav]$ echo $?
0

Perhaps these lines should be return 1;

from cfkey.c:

if (fd < 0)
   {
   printf("Ppen %s failed: %s.",CFPRIVKEYFILE,strerror(errno));
   return 0;
   }
 
if ((fp = fdopen(fd, "w")) == NULL )
   {
   printf("fdopen %s failed: %s.",CFPRIVKEYFILE, strerror(errno));
   close(fd);
   return 0;
   }

if (fd < 0)
   {
   printf("open %s failed: %s.",CFPUBKEYFILE,strerror(errno));
   return 0;
   }
 
if ((fp = fdopen(fd, "w")) == NULL )
   {
   printf("fdopen %s failed: %s.",CFPUBKEYFILE, strerror(errno));
   close(fd);
   return 0;
   }



-- 
Christian Pearce
http://www.sysnav.com
http://www.commnav.com
http://www.perfectorder.com

signature.asc
Description: This is a digitally signed message part