Re: allow spaces in build tree path

[Ralf Wildenhues]

* Jim Meyering wrote on Sun, Oct 22, 2006 at 07:43:12PM CEST:
> Ralf Wildenhues <address@hidden> wrote:
> 
> > If there is interest, I can try to prepare a similar patch for spaces in
> > the absolute source tree path; as long as $srcdir does not contain them,
> > that should still work in coreutils, I think.
> 
> Sure.

Oh well.  I forgot that Automake doesn't cope with it too well:
am_aux_dir is computed as absolute path, and thus references to scripts
like `missing' and `install-sh' break.  So, for coreutils the pain
enduring user trying to make do with a source path with spaces may need
to set $MISSING and $install_sh to point to some scripts (either
reachable in $PATH (e.g. by putting the build-aux dir in the PATH), or
with an absolute name not containing spaces), and must use a compiler
that understands `-c -o'.  And the patch below.

Cheers,
Ralf

2006-10-22  Ralf Wildenhues  <address@hidden>

        * tests/chmod/c-option: Double-quote instances of `$abs_srcdir'.
        * tests/cp/cp-parents: Likewise.
        * tests/mkdir/parents: Likewise.
        * tests/mkdir/perm: Likewise.

Index: tests/chmod/c-option
===================================================================
RCS file: /cvsroot/coreutils/coreutils/tests/chmod/c-option,v
retrieving revision 1.7
diff -u -r1.7 c-option
--- tests/chmod/c-option        22 Oct 2006 17:43:56 -0000      1.7
+++ tests/chmod/c-option        22 Oct 2006 19:41:11 -0000
@@ -50,7 +50,7 @@
   (exit 1); exit 1
 fi
 
-. $abs_srcdir/../setgid-check
+. "$abs_srcdir"/../setgid-check
 
 fail=0
 
Index: tests/cp/cp-parents
===================================================================
RCS file: /cvsroot/coreutils/coreutils/tests/cp/cp-parents,v
retrieving revision 1.17
diff -u -r1.17 cp-parents
--- tests/cp/cp-parents 22 Oct 2006 17:43:58 -0000      1.17
+++ tests/cp/cp-parents 22 Oct 2006 19:41:11 -0000
@@ -44,7 +44,7 @@
 mkdir -p $tmp || framework_failure=1
 cd $tmp || framework_failure=1
 
-. $abs_srcdir/../setgid-check
+. "$abs_srcdir"/../setgid-check
 
 mkdir foo bar || framework_failure=1
 mkdir -p a/b/c d e || framework_failure=1
Index: tests/mkdir/parents
===================================================================
RCS file: /cvsroot/coreutils/coreutils/tests/mkdir/parents,v
retrieving revision 1.10
diff -u -r1.10 parents
--- tests/mkdir/parents 22 Oct 2006 17:43:59 -0000      1.10
+++ tests/mkdir/parents 22 Oct 2006 19:41:11 -0000
@@ -44,7 +44,7 @@
   (exit 1); exit 1
 fi
 
-. $abs_srcdir/../setgid-check
+. "$abs_srcdir"/../setgid-check
 
 fail=0
 
@@ -56,12 +56,12 @@
 # Create an existing directory.
 umask 077
 mode_str=drwxr-x-wx
-mode_arg=`$abs_srcdir/../rwx-to-mode $mode_str`
+mode_arg=`"$abs_srcdir"/../rwx-to-mode $mode_str`
 mkdir -m $mode_arg a || fail=1
 
 # this `mkdir -p ...' shouldn't change perms of existing dir `a'.
 d_mode_str=drwx-w--wx
-d_mode_arg=`$abs_srcdir/../rwx-to-mode $d_mode_str`
+d_mode_arg=`"$abs_srcdir"/../rwx-to-mode $d_mode_str`
 mkdir -p -m $d_mode_arg a/b/c/d
 
 # Make sure the permissions of `a' haven't been changed.
Index: tests/mkdir/perm
===================================================================
RCS file: /cvsroot/coreutils/coreutils/tests/mkdir/perm,v
retrieving revision 1.21
diff -u -r1.21 perm
--- tests/mkdir/perm    22 Oct 2006 17:43:59 -0000      1.21
+++ tests/mkdir/perm    22 Oct 2006 19:41:11 -0000
@@ -45,8 +45,8 @@
   (exit 1); exit 1
 fi
 
-. $abs_srcdir/../setgid-check
-. $abs_srcdir/../umask-check
+. "$abs_srcdir"/../setgid-check
+. "$abs_srcdir"/../umask-check
 
 fail=0