bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#17863: Testsuite summary for GNU coreutils 8.22


From: Pádraig Brady
Subject: bug#17863: Testsuite summary for GNU coreutils 8.22
Date: Wed, 02 Jul 2014 19:50:13 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2

On 07/02/2014 05:58 PM, Bernhard Voelker wrote:
> On 07/02/2014 03:59 PM, Pádraig Brady wrote:
>> diff --git a/tests/ls/readdir-mountpoint-inode.sh 
>> b/tests/ls/readdir-mountpoint-inode.sh
>> index dabd661..b8691ea 100755
>> --- a/tests/ls/readdir-mountpoint-inode.sh
>> +++ b/tests/ls/readdir-mountpoint-inode.sh
>> @@ -21,8 +21,8 @@ print_ver_ ls
>>
>>   # We use --local here so as to not activate
>>   # potentially very many remote mounts.
>> -mount_points=$(df --local -P 2>&1 | sed -n 's,.*[0-9]% \(/.\),\1,p')
>> -test -z "$mount_points" &&
>> +df --local -P 2>&1 | sed -n 's,.*[0-9]% \(/.\),\1,p' > mount_points
>> +test -s mount_points ||
>>      skip_ "this test requires a non-root mount point"
> 
> Wouldn't the newer --output be clearer nowadays?
>   $ df --local --out=target | sed -n '/^\/./p' > mount_points

Pushed with that improvement.

thanks for the review!

Pádraig






reply via email to

[Prev in Thread] Current Thread [Next in Thread]