|
From: | Pádraig Brady |
Subject: | bug#61386: [PATCH] cp,mv,install: Disable sparse copy on macOS |
Date: | Mon, 20 Feb 2023 21:14:36 +0000 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Thunderbird/109.0 |
On 20/02/2023 19:35, George Valkov wrote:
On 2023-02-20, at 7:49 PM, Pádraig Brady <P@draigBrady.com> wrote: On 20/02/2023 15:02, George Valkov wrote:Hi Paul, the following tests fail after your patch: FAIL: tests/split/filter.sh FAIL: tests/split/b-chunk.sh FAIL: tests/split/l-chunk.shThese look unrelated and may be due to some other change in your environment. Specifically lseek() is failing on /dev/null and returning: split: /dev/null: cannot determine file sizeI deleted the lines that were introduced by the patch in unistd.in.h, then make clean; make -j 16 and ran all tests: back to 5 failed. Then I restored the deleted lines, rebuild and I got 9 failed tests again.
Oh right sorry. I think I see what's happening. Since https://github.com/coreutils/gnulib/commit/4db8db34 gnulib has been unconditionally replacing lseek() on macos. Now with SEEK_DATA undefined that replaced lseek() will run the code intended for BeOS. So either the lseek.m4 or lseek.c needs adjusting accordingly. cheers, Pádraig
[Prev in Thread] | Current Thread | [Next in Thread] |