Re: [Bug-cpio] cpio 2.4.2 put NULL pad in the middle of a file header

[Sergey Poznyakoff]

Hi Matthew,

Sorry it took me so long to reply.

> Looking at util.c I can make a guess about why this happened, and if
> my guess is correct the problem would also be present in version 2.5.
> 
> For most output, the functions copy_files_disk_to_*() call
> *_buffered_write() -- which functions of course buffer.  However, when
> cpio emits the error message above, it calls write_nuls_to_file(),
> which does *not* buffer:

Yes, you are right. Moreover, write_nuls_to_file incorrectly used
'extra_size' instead of 'blocks' which lead to creating archives
with the wrong length.

Both bugs are fixed in the repository. Thank you.

Regards,
Sergey