[bugs #4293] make install does not respect DESTDIR when generating localstatedir

[James Youngman]

This mail is an automated notification from the bugs tracker
 of the project: findutils.

/**************************************************************************/
[bugs #4293] Latest Modifications:

Changes by: 
                James Youngman <address@hidden>
'Date: 
                Fri 11/19/04 at 23:18 (GMT)

            What     | Removed                   | Added
---------------------------------------------------------------------------
         Assigned to | None                      | jay
              Status | Open                      | Closed
       Fixed Release | None                      | 4.2.5







/**************************************************************************/
[bugs #4293] Full Item Snapshot:

URL: <http://savannah.gnu.org/bugs/?func=detailitem&item_id=4293>
Project: findutils
Submitted by: Andreas Metzler
On: Sun 07/13/03 at 09:04

Category:  None
Severity:  5 - Average
Item Group:  None
Resolution:  Fixed
Privacy:  Public
Assigned to:  jay
Originator Name:  
Originator Email:  
Status:  Closed
Release:  None
Fixed Release:  4.2.5


Summary:  make install does not respect DESTDIR when generating localstatedir

Original Submission:  
Version: 4.1.20

locate/Makefile.* does not respect DESTDIR when generating localstatedir

Fix is straightforward, change locate/Makefile.*
- $(top_srcdir)/mkinstalldirs $(localstatedir)
+ $(top_srcdir)/mkinstalldirs $(DESTDIR)$(localstatedir)

       cu andreas


Follow-up Comments
------------------


-------------------------------------------------------
Date: Mon 11/08/04 at 21:58         By: James Youngman <jay>
This problem is fixed in the CVS code for findutils.
To resolve your problem, you could either wait for the 
next official release of findutils, or check out a copy 
of the code from the CVS repository for findutils.


-------------------------------------------------------
Date: Sun 11/07/04 at 08:37         By: Andreas Metzler <ametzler>
Jay wrote:
> Yours is a clearly-worded comment, but I don't understand > it. Firstly, the 
> construct you're talking about appears in > the Makefile.in, but not in the 
> Makefile.am file. Hence it > is being put into the Makefile.in file by 
> Automake. Is
> this a bug in Automake?

The construct appears in both Makefile.am (line and Makefile.in.
grep 'mkinstalldirs $(locals'  locate/Makefile.*
See patch attached to the bugreport, no bug in automake.

> Secondly, while I understand the physical nature of the
> change you suggest, what is its effect and why is it
> necessary?

"make DESTDIR" is designed to completely install the software under a temporary 
different location instead of /, it is e.g. used to build rpm or Debian 
packages. (During build you install in temporary directory as unprivileged 
user, tar it up and you are basically done.)

Currently locate/Makefile.* does not respect DESTDIR completely, with "make 
DESTDIR=/tmp/find install" it will put locate in /tmp/find/usr/bin/locate but 
it will try to generate the localstatedir (used for the locate-db) in /, i.e. 
try "mkdir /$localstatedir" instead of "mkdir /tmp/find/$localstatedir".

cu andreas

PS: sorry for the delayed response, but savannah had failed to send me a 
emailnotification on your followup.

-------------------------------------------------------
Date: Sun 10/31/04 at 17:10         By: James Youngman <jay>
Yours is a clearly-worded comment, but I don't understand it.  Firstly, the 
construct you're talking about appears in the Makefile.in, but not in the 
Makefile.am file.  Hence it is being put into the Makefile.in file by Automake. 
 Is this a bug in Automake?

Secondly, while I understand the physical nature of the change you suggest, 
what is its effect and why is it necessary?






File Attachments
-------------------

-------------------------------------------------------
Date: Sun 11/07/04 at 08:25  Name: fixbroken-DESTDIR.diff  Size: 1.04KB   By: 
ametzler
patch against current CVS
http://savannah.gnu.org/bugs/download.php?item_id=4293&amp;item_file_id=1842






For detailed info, follow this link:
<http://savannah.gnu.org/bugs/?func=detailitem&item_id=4293>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/