[bugs #7266] Linux device number bug report

[James Youngman]

This mail is an automated notification from the bugs tracker
 of the project: findutils.

/**************************************************************************/
[bugs #7266] Latest Modifications:

Changes by: 
                James Youngman <address@hidden>
'Date: 
                Sun 11/21/2004 at 16:59 (GMT)

            What     | Removed                   | Added
---------------------------------------------------------------------------
          Resolution | None                      | Invalid
         Assigned to | None                      | jay
              Status | Open                      | Closed


------------------ Additional Follow-up Comments ----------------------------
The findutils code uses the header file sysmacros.h, which is provided by the 
system.  This defines the macros major() and minor().  If those produce 32-bit 
values, "listfile.c" will cope with them (as unsigned longs).     The macro 
definitions for major and minor are only used when the system doesn't define 
these - as the code snipped you provided actually shows.  Hence I see no 
problem here.






/**************************************************************************/
[bugs #7266] Full Item Snapshot:

URL: <http://savannah.gnu.org/bugs/?func=detailitem&item_id=7266>
Project: findutils
Submitted by: 0
On: Thu 01/15/2004 at 09:13

Category:  find
Severity:  3 - Ordinary
Item Group:  None
Resolution:  Invalid
Privacy:  Public
Assigned to:  jay
Originator Name:  
Originator Email:  
Status:  Closed
Release:  None
Fixed Release:  None


Summary:  Linux device number bug report

Original Submission:  
Hello,

I have some questions about device number extension.

In Linux kernel 2.6, device number will be extended from 16-bit to 32-bit. All 
utilities and libraries should make corresponding extension for this new 
feature in kernel 2.6. 

I find that “findutils-4.1.7” uses structure dev_t and operates the device 
number as 16-bit.
------------------------------------------------------------------------------------------
1. lib/listfile.c line 160:

#ifdef major   /* Might be defined in sys/types.h.  */
#define HAVE_MAJOR
#endif
#ifndef HAVE_MAJOR
#define major(dev)  (((dev) >> 8) & 0xff)
#define minor(dev)  ((dev) & 0xff)
#endif

This is a backup for lost of system defined macro major and minor, but all of 
these operations 
look dev_t as 16 bits instead of 32 bits, so they will call problem when 
actually use them.
------------------------------------------------------------------------------------------

Since I didn’t find any information about this aspect in homepage of this 
package, I wonder whether the latest version has completed the device number 
extension? If not, will it be completed in the future? And when?

Looking forward to answering.


Follow-up Comments
------------------


-------------------------------------------------------
Date: Sun 11/21/2004 at 16:59       By: James Youngman <jay>
The findutils code uses the header file sysmacros.h, which is provided by the 
system.  This defines the macros major() and minor().  If those produce 32-bit 
values, "listfile.c" will cope with them (as unsigned longs).     The macro 
definitions for major and minor are only used when the system doesn't define 
these - as the code snipped you provided actually shows.  Hence I see no 
problem here.

-------------------------------------------------------
Date: Mon 05/03/2004 at 10:02       By: James Youngman <jay>
Looking at linux/kdev_t.h, the device numbers exposed to the 
user level still seems to use 8-bit major and minor numbers.  
The filesystem level uses larger sizes, but the userland interface does not.  
Hence I can't test your proposed extension.













For detailed info, follow this link:
<http://savannah.gnu.org/bugs/?func=detailitem&item_id=7266>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/