Re: [PATCH] fts: introduce FTS_NOATIME

[Paul Eggert]

On 07/07/11 10:41, Eric Blake wrote:
> This gives clients the option to try a non-invasive traversal,

Thanks for doing that; a couple of minor comments:

> -            int fd = open (".", O_SEARCH);
> +            int fd = open (".",
> +                           O_SEARCH | (ISSET (FTS_NOATIME) ? O_NOATIME : 0));

Shouldn't this use diropen rather than open?  Then you don't need
to worry about checking the flag here.  (This comment applies to
the existing code, too.)

> +          int parent_fd = openat (cwd_fd, "..", O_SEARCH | O_NOATIME);

This uses O_NOATIME even when the user hasn't asked for it.