[bug #57839] Remove/fix getdtablesize tests

[Truls Asheim]

Follow-up Comment #2, bug #57839 (project findutils):

Sorry about not including the test log. Here it is:

======================================================
   GNU findutils 4.7.0: gnulib-tests/test-suite.log
======================================================

# TOTAL: 236
# PASS:  204
# SKIP:  30
# XFAIL: 0
# FAIL:  2
# XPASS: 0
# ERROR: 0

.. contents:: :depth: 2

[...]

FAIL: test-dup2
===============

test-dup2.c:164: assertion 'dup2 (fd, bad_fd - 1) == bad_fd - 1' failed
FAIL test-dup2 (exit status: 134)

FAIL: test-getdtablesize
========================

test-getdtablesize.c:32: assertion 'dup2 (0, getdtablesize() - 1) ==
getdtablesize () - 1' failed
FAIL test-getdtablesize (exit status: 134)

[...]

My understanding is that the test failures occur only when building against a
recent (2.30) glibc on older (2.6.x) kernels. The tests pass when building
using the Centos 6-native toolchain. I would therefore expect it to not be
limited to nix, but I don't have a lot of time in the near future to set up an
alternative build environment to test this, unfortunately.

There are some more details in the github link [1] I posted previously,
including the patch which was previously used to locally disable the tests for
nix builds. dup2 was still being tested, but the failing assertions using
values from getdtablesize() was removed.

Regarding your last point, coreutils tests not run by the nix build scripts
[2] in my case since I'm building to a non-standard store directory.

[1] https://github.com/NixOS/nixpkgs/pull/46669
[2]
https://github.com/NixOS/nixpkgs/blob/8731aaaf8b30888bc24994096db830993090d7c4/pkgs/tools/misc/coreutils/default.nix#L100


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?57839>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/