[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] browse-url.el mozilla tab support
From: |
Simon Josefsson |
Subject: |
Re: [PATCH] browse-url.el mozilla tab support |
Date: |
Thu, 10 Oct 2002 23:59:44 +0200 |
User-agent: |
Gnus/5.090008 (Oort Gnus v0.08) Emacs/21.2 (i386-debian-linux-gnu) |
Steve Youngs <youngs@xemacs.org> writes:
> |--==> "SJ" == Simon Josefsson <jas@extundo.com> writes:
>
> SJ> Steve, have you signed papers for browse-url.el? I wanted to get
> SJ> Emacs to include your XEmacs browse-url.el patch too. Thanks.
> SJ> (Maybe papers aren't required for that patch though..)
>
> Not for browse-url.el specifically, no. Let me know if you need it.
What does the Emacs maintainers think? Are papers necessary for the
following patch, which mimics already existing Galeon code?
--- browse-url.el.~1.23.~ 2002-07-25 20:49:46.000000000 +0200
+++ browse-url.el 2002-10-10 16:34:46.000000000 +0200
@@ -335,6 +335,13 @@
:type '(repeat (string :tag "Argument"))
:group 'browse-url)
+(defcustom browse-url-mozilla-new-window-is-tab nil
+ "*Whether to open up new windows in a tab or a new window.
+If non-nil, then open the URL in a new tab rather than a new window if
+`browse-url-mozilla' is asked to open it in a new window."
+ :type 'boolean
+ :group 'browse-url)
+
(defcustom browse-url-galeon-new-window-is-tab nil
"*Whether to open up new windows in a tab or a new window.
If non-nil, then open the URL in a new tab rather than a new window if
@@ -862,7 +873,8 @@
(setq url (replace-match
(format "%%%x" (string-to-char (match-string 0 url))) t t url)))
(let* ((process-environment (browse-url-process-environment))
- (process (apply 'start-process
+ (process
+ (apply 'start-process
(concat "mozilla " url) nil
browse-url-mozilla-program
(append
@@ -870,7 +882,11 @@
(list "-remote"
(concat "openURL("
url
- (if new-window ",new-window")
+ (if (browse-url-maybe-new-window
+ new-window)
+ (if browse-url-mozilla-new-window-is-tab
+ ",new-tab")
+ ",new-window")
")"))))))
(set-process-sentinel process
`(lambda (process change)