[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [patch 1/4] Rename isnand.h to isnand-nolibm.h, similarly for isnanf
From: |
Bruno Haible |
Subject: |
Re: [patch 1/4] Rename isnand.h to isnand-nolibm.h, similarly for isnanf.h. |
Date: |
Sat, 12 Jul 2008 02:12:50 +0200 |
User-agent: |
KMail/1.5.4 |
Hi Ben,
> I broke up the monolithic
> patch into four smaller patches as you requested.
Thanks a lot; it is much easier to review this way.
Part 1 is perfect (just an extraneous space in the ChangeLog entry).
Part 2: In m4/isnand.m4 the variable gl_func_isnand looks unused; can you add
a comment saying that it's used by isnan.m4?
The body of gl_BUILD_ISNAND has too much indentation. The
last line of macro gl_HAVE_ISNAND_NO_LIBM is also too much indented.
But otherwise it looks perfect.
Part 3: The body of gl_BUILD_ISNANF has too much indentation. Otherwise perfect
as well.
Part 4: The last line of the ChangeLog entry is extraneous.
The body of gl_BUILD_ISNANL has too much indentation.
gl_ISNAN needs to start with AC_REQUIRE([gl_MATH_H_DEFAULTS]) because
it sets REPLACE_ISNAN, assuming that REPLACE_ISNAN has its default
value set before.
Great work! Please apply these 4 patches.
Bruno
- new modules 'isnan', 'isnanf', 'isnand', Ben Pfaff, 2008/07/08
- Re: new modules 'isnan', 'isnanf', 'isnand', Simon Josefsson, 2008/07/08
- Re: new modules 'isnan', 'isnanf', 'isnand', Bruno Haible, 2008/07/08
- Re: new modules 'isnan', 'isnanf', 'isnand', Bruno Haible, 2008/07/08
- [patch 2/4] Add isnand module., Ben Pfaff, 2008/07/11
- [patch 1/4] Rename isnand.h to isnand-nolibm.h, similarly for isnanf.h., Ben Pfaff, 2008/07/11
- Re: [patch 1/4] Rename isnand.h to isnand-nolibm.h, similarly for isnanf.h.,
Bruno Haible <=
- Re: [patch 1/4] Rename isnand.h to isnand-nolibm.h, similarly for isnanf.h., Ben Pfaff, 2008/07/12
- Re: [patch 1/4] Rename isnand.h to isnand-nolibm.h, similarly for isnanf.h., Bruno Haible, 2008/07/12
- [patch 4/4] Add isnan module., Ben Pfaff, 2008/07/11
- [patch 3/4] Add isnanf module., Ben Pfaff, 2008/07/11