[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: move u64.h from sha512 to separate module?
From: |
Simon Josefsson |
Subject: |
Re: move u64.h from sha512 to separate module? |
Date: |
Mon, 30 Mar 2009 18:52:59 +0200 |
User-agent: |
Gnus/5.110011 (No Gnus v0.11) Emacs/23.0.90 (gnu/linux) |
Simon Josefsson <address@hidden> writes:
> Paul, Jim,
>
> The u64.h file, which is part of the sha512 module now, would be useful
> for me in gnutls where we currently have our own uint64_t replacement
> types and functions. How about making a separate module for it?
Any objections to the patch?
/Simon
> From c0f93a82f337acf77fe909e903b5d2135c558ca3 Mon Sep 17 00:00:00 2001
> From: Simon Josefsson <address@hidden>
> Date: Wed, 4 Mar 2009 02:36:00 +0100
> Subject: [PATCH] Add new module u64 based on u64.h from sha512.
>
> ---
> ChangeLog | 7 +++++++
> MODULES.html.sh | 3 ++-
> modules/crypto/sha512 | 2 +-
> modules/u64 | 17 +++++++++++++++++
> 4 files changed, 27 insertions(+), 2 deletions(-)
> create mode 100644 modules/u64
>
> diff --git a/ChangeLog b/ChangeLog
> index 86a7852..ae1fda8 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,3 +1,10 @@
> +2009-03-04 Simon Josefsson <address@hidden>
> +
> + * MODULES.html.sh: Mention u64.
> + * modules/u64: New module.
> + * modules/crypto/sha512: Depend on u64 module instead of providing
> + u64.h.
> +
> 2009-03-03 Bruno Haible <address@hidden>
>
> * doc/visibility.texi: Recommend to use HAVE_VISIBILITY as a C macro.
> diff --git a/MODULES.html.sh b/MODULES.html.sh
> index 6145234..c408a48 100755
> --- a/MODULES.html.sh
> +++ b/MODULES.html.sh
> @@ -1,6 +1,6 @@
> #!/bin/sh
> #
> -# Copyright (C) 2002-2008 Free Software Foundation, Inc.
> +# Copyright (C) 2002-2009 Free Software Foundation, Inc.
> #
> # This program is free software: you can redistribute it and/or modify
> # it under the terms of the GNU General Public License as published by
> @@ -3109,6 +3109,7 @@ func_all_modules ()
> func_module readutmp
> func_module random_r
> func_module sysexits
> + func_module u64
> func_module verror
> func_module visibility
> func_end_table
> diff --git a/modules/crypto/sha512 b/modules/crypto/sha512
> index d1236f3..ca17e1a 100644
> --- a/modules/crypto/sha512
> +++ b/modules/crypto/sha512
> @@ -5,10 +5,10 @@ Files:
> lib/sha512.h
> lib/sha512.c
> m4/sha512.m4
> -lib/u64.h
>
> Depends-on:
> stdint
> +u64
>
> configure.ac:
> gl_SHA512
> diff --git a/modules/u64 b/modules/u64
> new file mode 100644
> index 0000000..e875fe2
> --- /dev/null
> +++ b/modules/u64
> @@ -0,0 +1,17 @@
> +Description:
> +uint64_t-like operations that work even on hosts lacking uint64_t
> +
> +Files:
> +lib/u64.h
> +
> +Depends-on:
> +stdint
> +
> +Include:
> +"u64.h"
> +
> +License:
> +LGPLv2+
> +
> +Maintainer:
> +Paul Eggert