bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: init.sh: enable MALLOC_PERTURB_


From: Jim Meyering
Subject: Re: init.sh: enable MALLOC_PERTURB_
Date: Mon, 10 May 2010 17:24:04 +0200

Peter O'Gorman wrote:

> On Sun, May 09, 2010 at 10:47:07PM +0200, Jim Meyering wrote:
>
>> +# Enable glibc's malloc-perturbing option.
>> +# This is cheap and useful for exposing code that depends on the fact that
>> +# malloc-related functions often return memory that is mostly zeroed.
>> +# If you have the time and cycles, use valgrind to do an even better job.
>> +${MALLOC_PERTURB_=87}
>> +export MALLOC_PERTURB_
>
> PASS: test-verify
> 87: not found
> PASS: test-verify.sh
>
> Maybe you want:
>
> : ${MALLOC_PRETURB_=87}

Thanks again.
Here's what I have pushed:

>From f0f1414d0d1f5a904940fac105b8838f132b946b Mon Sep 17 00:00:00 2001
From: Peter O'Gorman <address@hidden>
Date: Mon, 10 May 2010 17:23:08 +0200
Subject: [PATCH] init.sh: fix a typo

* tests/init.sh: Correct typo in MALLOC_PERTURB_ initialization.
---
 ChangeLog     |    5 +++++
 tests/init.sh |    2 +-
 2 files changed, 6 insertions(+), 1 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 5510f68..8c762cf 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2010-05-10  Peter O'Gorman  <address@hidden>
+
+       init.sh: fix a typo
+       * tests/init.sh: Correct typo in MALLOC_PERTURB_ initialization.
+
 2010-05-10  Jim Meyering  <address@hidden>

        maint.mk: avoid using a temporary file in the always-defined-macros 
check
diff --git a/tests/init.sh b/tests/init.sh
index 1c0b4b4..05a983a 100644
--- a/tests/init.sh
+++ b/tests/init.sh
@@ -98,7 +98,7 @@ test -n "$EXEEXT" && shopt -s expand_aliases
 # This is cheap and useful for exposing code that depends on the fact that
 # malloc-related functions often return memory that is mostly zeroed.
 # If you have the time and cycles, use valgrind to do an even better job.
-${MALLOC_PERTURB_=87}
+: ${MALLOC_PERTURB_=87}
 export MALLOC_PERTURB_

 # We use a trap below for cleanup.  This requires us to go through
--
1.7.1.189.g07419



reply via email to

[Prev in Thread] Current Thread [Next in Thread]