[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] strerror: work around FreeBSD bug
From: |
Eric Blake |
Subject: |
Re: [PATCH 2/2] strerror: work around FreeBSD bug |
Date: |
Tue, 07 Jun 2011 21:50:37 -0600 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110428 Fedora/3.1.10-1.fc14 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.10 |
On 06/07/2011 05:09 PM, Eric Blake wrote:
> On 06/07/2011 03:29 AM, Bruno Haible wrote:
>> Eric Blake wrote:
>>> * lib/strerror.c (strerror): Special case 0.
>>
>> Thanks.
>>
>> On MacOS X 10.5, I'm still seeing these failures:
>>
>> test-strerror.c:63: assertion failed
>> FAIL: test-strerror
>
> strerror(0) misbehavior. Hmm, while FreeBSD was setting EINVAL to make
> the failure explicit, MacOS is claiming success while still outputting
> "Unknown error: 0". I'll fix that with a strstr() test in the .m4 files.
Oh hideous.
strerror(0) => Unknown error: 0
strerror_r(0,buf,len) => Undefined error: 0
strerror(-1) => Unknown error: -1
strerror_r(-1,buf,len) => Unknown error: -1
I don't think POSIX requires the same strings for the two
implementations, but MacOS is the first implementation where the strings
are intentionally different, but only for a single errnum value. Fix
coming up soon.
--
Eric Blake address@hidden +1-801-349-2682
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [PATCHv2] strerror: drop strerror_r dependency, (continued)
- Re: [PATCHv2] strerror: drop strerror_r dependency, Bruno Haible, 2011/06/03
- [PATCH 1/2] strerror-override: avoid bloating errno module, Eric Blake, 2011/06/06
- [PATCH 2/2] strerror: work around FreeBSD bug, Eric Blake, 2011/06/06
- Re: [PATCH 2/2] strerror: work around FreeBSD bug, Bruno Haible, 2011/06/07
- Re: [PATCH 2/2] strerror: work around FreeBSD bug, Eric Blake, 2011/06/07
- Re: [PATCH 2/2] strerror: work around FreeBSD bug,
Eric Blake <=
- MacOS strerror_r [was: [PATCH 2/2] strerror: work around FreeBSD bug], Eric Blake, 2011/06/08
- Re: MacOS strerror_r, Eric Blake, 2011/06/08
- Re: [PATCH 2/2] strerror: work around FreeBSD bug, Eric Blake, 2011/06/08
Re: [PATCHv2] strerror: drop strerror_r dependency, Bruno Haible, 2011/06/04