[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: fseeko, ftello: avoid inline function in include file
From: |
Eric Blake |
Subject: |
Re: fseeko, ftello: avoid inline function in include file |
Date: |
Mon, 13 Jun 2011 09:55:43 -0600 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110419 Red Hat/3.1.10-1.el6_0 Mnenhy/0.8.3 Thunderbird/3.1.10 |
On 06/13/2011 09:38 AM, Bruno Haible wrote:
> Eric Blake wrote:
>> This looks reasonable to me (and no problem on the license change).
>
> Good, I've applied it, together with the same change for fseeko:
>
>
> 2011-06-13 Bruno Haible <address@hidden>
>
> fseeko: Provide a non-inline replacement of fseek().
> * lib/stdio.in.h (fseek): Don't provide if module 'fseek' is not used.
> * modules/fseeko (Depends-on): Add fseek.
> * modules/fseek (License): Change to LGPLv2+.
Actually, I'm wondering if we need modules/fseeko to depend on
modules/fseek, or if we can come up with some other approach. After
all, the whole idea is that portable programs should only be using
fseeko, not fseek. But by making fseeko depend on fseek, then
stdio.in.h will always end up replacing fseek even if it is not going to
be used, and we lose the ability to issue gcc warnings about unintended
use of fseek when fseeko should have been used.
Of course, the fseeko replacement needs to fix flaws in the native fseek
if there is no native fseeko, but if we can make it do that without also
dragging in the fseek module, that would be better. I'm okay with a
converse dependency, though, where fseek depends on fseeko.
--
Eric Blake address@hidden +1-801-349-2682
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature