[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] maint.mk: add syntax-check to avoid char[PATH_MAX]
|
From: |
Paul Eggert |
|
Subject: |
Re: [PATCH] maint.mk: add syntax-check to avoid char[PATH_MAX] |
|
Date: |
Wed, 22 Jun 2011 14:49:12 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110428 Fedora/3.1.10-1.fc14 Thunderbird/3.1.10 |
On 06/22/11 14:10, Eric Blake wrote:
> + @prohibit='\[PATH''_MAX'
Doesn't this go too far? For example, gnulib's lib/stat.c does this:
/* Due to mingw's oddities, ...
Fortunately, mingw PATH_MAX is small enough for stack
allocation. */
char fixed_name[PATH_MAX + 1] = {0};
and this seems reasonable, so long as the code in question runs
only when PATH_MAX is known to be a reasonable constant.